JuliaTesting / ReferenceTests.jl

Utility package for comparing data against reference files
https://juliatesting.github.io/ReferenceTests.jl/latest/
Other
82 stars 14 forks source link

porting to JuliaTesting #54

Closed johnnychen94 closed 4 years ago

johnnychen94 commented 4 years ago

This idea is originally proposed by @oxinabox in slack

Evizero commented 4 years ago

I am happy to press the transfer button at any time really. Main reason I didn't do that yet, is because I am not sure if it can break anything. However, I am not up to speed about any other steps that need to be taken and would appreciate someone else performing them if possible.

johnnychen94 commented 4 years ago

The old URL is still valid even if it's transferred to a new place. We've transferred ImageContrastAdjustment to Images recently, and it's:

  1. hit the transfer button
  2. update CI settings

Ref: https://github.com/JuliaImages/Images.jl/pull/855#issuecomment-569912692

oxinabox commented 4 years ago

Update the URL in the registry too for completeness. (Even though it will redirect until something else (like a fork) is put at old URL) Full instructions: https://github.com/JuliaRegistries/General#how-do-i-transfer-a-package-to-an-organization-or-another-user

johnnychen94 commented 4 years ago

I'll fix the CI and submit a PR to General later today/tomorrow.

Evizero commented 4 years ago

I pushed the button. welcome to your new home, old friend.

Thank you two! This is surely the right place. It was your contributions that turned it into a proper package after all

johnnychen94 commented 4 years ago

CI fixed in #56

The documentation tags for v0.9.0 and v0.9.1 are missing due to Travis grammar changes months ago(IIUC it's the cause), but that's not a big deal; as long as we tag a new v0.9.2 version, there will be a v0.9 tag.

kimikage commented 4 years ago

a remembrance :smile: https://github.com/JuliaTesting/ReferenceTests.jl/blame/30aa43f/README.md#L88

johnnychen94 commented 4 years ago

Yes, the documentation definitely needs an update, I plan to do that after #61

Currently, the documentation is basically identical to README.md

kimikage commented 4 years ago

It's an issue with the broken link, not the documentation.