search

JuliaTesting / ReferenceTests.jl

Utility package for comparing data against reference files
https://juliatesting.github.io/ReferenceTests.jl/latest/
Other
82 stars 14 forks source link

rework `default_rendermode` and add tests for `render` #66

Open johnnychen94 opened 4 years ago

johnnychen94 commented 4 years ago

This is a sub PR of #61

The previous default_rendermode(format, data) is problematic that the render pipeline is showing the original data instead of the encoded data.

https://github.com/JuliaTesting/ReferenceTests.jl/blob/30aa43f7849eee74f6fc8057b652c8fa626cda57/src/test_reference.jl#L115

For example, setting default_rendermode(::SHA256, img) to BeforeAfterLimited doesn't make much sense to me.