Add a few precompiles - Githubissues

JuliaTesting / ReferenceTests.jl

Utility package for comparing data against reference files

https://juliatesting.github.io/ReferenceTests.jl/latest/

Other

82 stars 14 forks source link

Add a few precompiles #69

Closed timholy closed 3 years ago

timholy commented 3 years ago

This also improves the inferrability of loadfile method.

oxinabox commented 3 years ago

LGTM. Can you bump the version so can tag a release?

timholy commented 3 years ago

I'm pretty sure the error on 1.0 is a registry bug (some kind of compat hell with specific package combinations). I had the same error before I added any bounds to the test dependencies, I was hoping that would make it go away. But no luck. Still, it seems useful to have them.

timholy commented 3 years ago

OK, specifically the issue was that Julia 1.0 can't downgrade package dependencies in order to fix test dependencies. DataFrames hasn't released a version that's compatible with PrettyTables 0.11, which is the only release series compatible with Reexport 1.0, which was installed by something else. I had missed DataFrames in my "add test-deps compat"; unfortunately, once added it still doesn't pass. I think the options are:

add DataFrames as a "fake" dependency
ignore the failure on Julia 1.0 (it will go away once DataFrames supports PrettyTables 0.11, or if PrettyTables 0.10.x makes a compat release with Reexport)
drop support for Julia 1.0

Thoughts?

timholy commented 3 years ago

Oh, and I don't have merge privileges so someone will have to do the honors.

oxinabox commented 3 years ago

Yeah it is that thing where 1.0 can't downgrade packages. I think we can just ingore the failures I will open an issue

oxinabox commented 3 years ago

@JuliaRegistrator register

JuliaRegistrator commented 3 years ago

Comments on pull requests will not trigger Registrator, as it is disabled. Please try commenting on a commit or issue.