Closed Ayushk4 closed 5 years ago
This is indeed an enhancement
Can you check out why CI is failing?
Here's the Travis error -> The job exceeded the maximum time limit for jobs, and has been terminated.
While testing it has to download Wiki Corpus ( 1.3 GB ), now this is causing CI to throw an error as it takes a lot of time.
The Travis tests pass for 1.0
. Working on appveyor now.
Appveyor passes for julia 1.0.
@oxinabox This is complete from my side. You may review this patch.
Thanks, this is clearly an improvement. I will merge once CI passes
Travis is throwing an error because downloading WikiCorpus takes long. The job exceeded the maximum time limit for jobs, and has been terminated.
What should I do in this case?
For now, lets just do
if ENV["CI"]=="true" && ENV["TRAVIS"]=="true"
@warn "WikiCorpus tests disabled on TravisCI"
else
... # Do the tests
end
Longer term solutions, for another PR:
I have made the changes to skip WikiCorpus in Travis's environment.
Both Travis and Appveyor builds now pass on 1.0
.
Cool excellent. Thanks
Fixed
MultiResolutionIterators.levelname_map
here and added more in others. https://github.com/JuliaText/CorpusLoaders.jl/blob/2bb7d7e0b4a04fc534f6e4900f4e9a2b04c30945/src/Senseval3.jl#L22