Fix levelname Mapping and deprecations

JuliaText / CorpusLoaders.jl

A variety of loaders for various NLP corpora.

Other

32 stars 13 forks source link

Fix levelname Mapping and deprecations #21

Closed Ayushk4 closed 5 years ago

Ayushk4 commented 5 years ago

Fixed MultiResolutionIterators.levelname_map here and added more in others. https://github.com/JuliaText/CorpusLoaders.jl/blob/2bb7d7e0b4a04fc534f6e4900f4e9a2b04c30945/src/Senseval3.jl#L22

oxinabox commented 5 years ago

This is indeed an enhancement

Can you check out why CI is failing?

Ayushk4 commented 5 years ago

Here's the Travis error -> The job exceeded the maximum time limit for jobs, and has been terminated. While testing it has to download Wiki Corpus ( 1.3 GB ), now this is causing CI to throw an error as it takes a lot of time.

Ayushk4 commented 5 years ago

The Travis tests pass for 1.0. Working on appveyor now.

Ayushk4 commented 5 years ago

Appveyor passes for julia 1.0.

Ayushk4 commented 5 years ago

@oxinabox This is complete from my side. You may review this patch.

oxinabox commented 5 years ago

Thanks, this is clearly an improvement. I will merge once CI passes

Ayushk4 commented 5 years ago

Travis is throwing an error because downloading WikiCorpus takes long. The job exceeded the maximum time limit for jobs, and has been terminated. What should I do in this case?

oxinabox commented 5 years ago

For now, lets just do

if ENV["CI"]=="true" && ENV["TRAVIS"]=="true"
    @warn "WikiCorpus tests disabled on TravisCI"
else
... # Do the tests
end

Longer term solutions, for another PR:

Setup CI on CicleCI (related: https://github.com/invenia/PkgTemplates.jl/issues/77)
Make a smaller subset of the WikiCorpus for testing purposes

Ayushk4 commented 5 years ago

I have made the changes to skip WikiCorpus in Travis's environment. Both Travis and Appveyor builds now pass on 1.0.

oxinabox commented 5 years ago

Cool excellent. Thanks