JuliaText / TextAnalysis.jl

Julia package for text analysis
Other
374 stars 96 forks source link

Remove missing functions #120

Closed aquatiko closed 5 years ago

aquatiko commented 5 years ago

Removing the exported functions which are not defined. Closes: https://github.com/JuliaText/TextAnalysis.jl/issues/93

aviks commented 5 years ago

Hi Rohit, thanks for this, but in this case, we just want to remove the symbols from the export list. These functions used to exist, but were moved into prepare!. This is a bit confusing no doubt, sorry.

aquatiko commented 5 years ago

@aviks I wasn't aware of the functions being removed as they are still in the docs. If they do not exist now.. Should the docs be updated to reflect that and mention the usage of prepare! instead of these functions?

aviks commented 5 years ago

Yes, the docs should be updated to mention prepare!. It's a big problem that it hasn't yet been.

aquatiko commented 5 years ago

@aviks Can this be merged now?