search

JuliaText / TextAnalysis.jl

Julia package for text analysis
Other
373 stars 95 forks source link

Remove HTML style tags in preprocessing #137

Closed phereford closed 5 years ago

phereford commented 5 years ago

As we remove HTML tags in preprocessing, we should also be cognizant of any rogue <style> tags and remove those as needed as well.

Let me know if there is anything else I can add or change to get this merged in. Thank you for this wonderful library!

Ayushk4 commented 5 years ago

Thank you so much for this phereford.

It will be great if you could add some tests to test/preprocessing.jl.

aviks commented 5 years ago

Thanks. Yes, some tests would be good, to ensure that we do not break this functionality in the future.

phereford commented 5 years ago

@aviks and @Ayushk4 thanks for the feedback! I will add unit tests now.

phereford commented 5 years ago

@aviks and @Ayushk4 I added a unit test styled like the other preprocessing unit tests. Let me know if there is anything else I can provide.

aviks commented 5 years ago

Thanks!