search

JuliaText / TextAnalysis.jl

Julia package for text analysis
Other
373 stars 95 forks source link

Update ngramizer.jl #148

Closed djokester closed 5 years ago

djokester commented 5 years ago

The previous function returned all the ngrams from n to 1. This error is also recorded in the documentation. image

Ayushk4 commented 5 years ago

Thank you so much for this. May you please, update the documents and add the tests as well?

djokester commented 5 years ago

Updated Tests and Documentation to reflect the changes.

tanmaykm commented 5 years ago

That could have been better implemented as an option IMO. Or by having a variant of ngrams that took a list of ngrams to generate. Useful while indexing for text search.

Ayushk4 commented 5 years ago

We could open an issue for the same should be good first PR.