Closed Ayushk4 closed 5 years ago
This is good. Thanks @Ayushk4
One comment is that the show_repl
should be moved to show(::IO, ::MIME"text/plain", c)
. See here for the current state of these functions: https://docs.julialang.org/en/v1/manual/types/#man-custom-pretty-printing-1
Thanks Ayush
A good ( bad ? ) news - now that this is fixed. The outputs of print and show will be changed to the ones defined in show.jl
.
For eg:
Earlier one
julia> doc = StringDocument("this is a doc")
StringDocument{String}("this is a doc", TextAnalysis.DocumentMetadata(Languages.English(), "Untitled Document", "Unknown Author", "Unknown Time"))
Newer one
julia> doc = StringDocument("This is a String Document")
A StringDocument{String}
* Language: Languages.English()
* Title: Untitled Document
* Author: Unknown Author
* Timestamp: Unknown Time
* Snippet: This is a String Document
This means the documentation work done in #134, #147, #150 needs to be revised for the new changes.
Minor deprecations and bugs (similar to #153) fixed.
The function
summary
in show.jl (source) is named similar to Base.summary.@aviks What should I rename this to? Or should I extend Base.summary to support
AbstractDocument
,Corpus
types?