JuliaText / TextAnalysis.jl

Julia package for text analysis
Other
373 stars 95 forks source link

Fix deprecations in show.jl #155

Closed Ayushk4 closed 5 years ago

Ayushk4 commented 5 years ago

Minor deprecations and bugs (similar to #153) fixed.

The function summary in show.jl (source) is named similar to Base.summary.

@aviks What should I rename this to? Or should I extend Base.summary to support AbstractDocument, Corpus types?

aviks commented 5 years ago

This is good. Thanks @Ayushk4

One comment is that the show_repl should be moved to show(::IO, ::MIME"text/plain", c). See here for the current state of these functions: https://docs.julialang.org/en/v1/manual/types/#man-custom-pretty-printing-1

aviks commented 5 years ago

Thanks Ayush

Ayushk4 commented 5 years ago

A good ( bad ? ) news - now that this is fixed. The outputs of print and show will be changed to the ones defined in show.jl.

For eg: