Conditional Random Fields

JuliaText / TextAnalysis.jl

Julia package for text analysis

Other

373 stars 95 forks source link

Conditional Random Fields #162

Closed Ayushk4 closed 5 years ago

Ayushk4 commented 5 years ago

[X] Viterbi Decode
[X] Supports for training with Flux Layers
[X] Documentation
[X] Tests
[X] Extended example over the Flux layers

MikeInnes commented 5 years ago

Seems fine to me code style wise; @aviks don't know if you want any deeper look over this, but it's not a model I'm really familiar with.

Could probably use some tests / a usage demo but you have that listed. If this is something that's designed to be trained by users, rather than classifying things out of the box, maybe there's a case for just having it in Flux itself?

You might want to look at Flux.@treelike so that this model can be moved the the GPU and such.

Ayushk4 commented 5 years ago

@aviks Please review this PR.

aviks commented 5 years ago

I'm merging this here for now. It may be worth moving to Flux, but I don't want to make that a blocker for further work. Ayush, you may want to make a PR to Flux at some point with this model, but it's not urgent.