search

JuliaText / TextAnalysis.jl

Julia package for text analysis
Other
373 stars 95 forks source link

Throw appropriate error for pad_sequence input of length > maxlen #183

Open Ayushk4 opened 4 years ago

Ayushk4 commented 4 years ago

https://github.com/JuliaText/TextAnalysis.jl/blob/f11877268ba3911b30f7b13c549411a08cd380ad/src/sentiment.jl#L4

This function returns nothing in case the input length > maxlen. It will be better to have a proper error handling and err message display for this.

Ayushk4 commented 4 years ago

Thanks to @fungktt for pointing out the above.

bnriiitb commented 3 years ago

@Ayushk4 still some work needed on this?

Ayushk4 commented 3 years ago

I am currently waiting for a response from @sean-gauss , since they already sent a PR.

But, a PR is welcome for fixing this.