JuliaText / TextAnalysis.jl

Julia package for text analysis
Other
374 stars 96 forks source link

Return topics vs. documents results from LDA #86

Closed baggepinnen closed 6 years ago

baggepinnen commented 6 years ago

I should mention that I have just been playing around with this for fun and am not sure what I am doing, but it seems to return reasonable results in my analysis. Addresses #63

aviks commented 6 years ago

Thanks! looks good to me. Maybe add some documentation for this?

baggepinnen commented 6 years ago

Documentation added in #89 and 063cddfa97177ba2cbd90955a64ac8cf652a4c0c

aviks commented 6 years ago

I think the tests need to be fixed to incorporate the new return value.

Test Failed
  Expression: typeof(topics) <: SparseMatrixCSC
ERROR: LoadError: LoadError: There was an error during testing
while loading /home/travis/.julia/v0.6/TextAnalysis/test/lda.jl, in expression starting on line 15
baggepinnen commented 6 years ago

This seems to pass tests now. I submitted another PR to update the test infrastructure to use the built in functionality.