search

JuliaText / TextAnalysis.jl

Julia package for text analysis
Other
374 stars 96 forks source link

bug fixes for DTM constructor and for remove_patterns #94

Closed AsafManela closed 6 years ago

AsafManela commented 6 years ago

Note that the remove_patterns fix will have to be revisited to support julia 1.0 because SubString no longer has the endof field, but does have ncodeunits.

I added some utf8 chars to the test string which would fail before this fix.

aviks commented 6 years ago

Unfortunately this needs rebasing. (Don't worry if that gives you trouble -- I'll get to it in a few days)

AsafManela commented 6 years ago

It was a one line conflict, which is now resolved, and ready to be merged

aviks commented 6 years ago

Thanks Asaf, appreciate this.