search

JuliaText / WordNet.jl

A Julia package for Princeton's WordNet®.
Other
34 stars 11 forks source link

Should `dict` be hardcoded into the path? #1

Open oxinabox opened 8 years ago

oxinabox commented 8 years ago

Hi, Nice work, very handy for those of use doing NLP in julia.

I though I could use the copy of Wordnet I already had from NLTK. which depending on how NLTK is installed lived in <NLTKPATH>/nltk_data/corpora/wordnet

However within the corpus directory for NLTK's copy are the index files directly -- they are not inside a dict subdirectory. Since everything in the wordnet folder is inside the dict folder it is i guess not required.

Easy work around, either with simlinks or just downloading another wordnet copy.

jbn commented 8 years ago

It's been a while since I wrote this. And, I don't get to play with Julia that much these days.

Vaguely, I remember NLTK's wordnet not being version 3.0, ergo incompatible. But maybe not?

In any case, you're right, it' be more flexible with no hardcoded "dict" in the path. If you want to submit the patch / tests update, I'll pull it. Otherwise, I'll fix it later this week.

oxinabox commented 8 years ago

I am using this again. this week I need to deal with WordNet 2.1. You package seems to work fine with 2.1. :-)

One arguement infavor of putting the dict folder in the path is that if you have a full WordNet install it has many folders, only one of which is the dict folder. The rest holding commandline utilities and other things. This is the case for 2.1, and 3.0, and most wordnet releases.

But wordnet 3.1 (the lastest release) is distributed only as the dict folder -- but with instructions that if you want the rest of the utilities, then you should download wordnet 3.0 and replace the dict folder.

jbn commented 8 years ago

I just told Siri to remind me to try and patch this later. Sorry I never followed through.