Finish upgrading to Julia 0.7/1.0

JuliaText / WordNet.jl

A Julia package for Princeton's WordNet®.

Other

35 stars 11 forks source link

Finish upgrading to Julia 0.7/1.0 #14

Closed rdeits closed 5 years ago

rdeits commented 5 years ago

(this is a PR against the branch in https://github.com/JuliaText/WordNet.jl/pull/12 )

Removes FactCheck
dirname(@__FILE__) -> @__DIR__
AbstractString -> String
Removes Compat
Misc. 0.7 deprecation fixes
Updates to the new DataDeps.jl API
Updates the CI configurations
"Douches'" -> "Doches'" in the Readme

oxinabox commented 5 years ago

AbstractString -> String is a change, but I think a good one, I am guessing it is a legacy of julia 0.3 or so splitting ASCIIString from UTF8String

oxinabox commented 5 years ago

Other than this one comment, This LGTM. Once that is addressed I'll merge this into #12 and then #12 to master and tag a release

oxinabox commented 5 years ago

Great, thanks