JuliaText / WordNet.jl

A Julia package for Princeton's WordNet®.
Other
34 stars 11 forks source link

Add Sensekeys #2

Closed oxinabox closed 8 years ago

oxinabox commented 8 years ago

Sometimes -- often, corpora annotate senses with the wordnet's Sensekeys.

I have added these to the package.

They are useful when dealing with corpora such as, SemCor. and various semeval tasks eg SemEval 2007 task7.

Right now this is a one-way map -- that is to say that given a Synset and a Lemma, there is a method to produce its Sense Key.

I might make a method to go the other way; if I find it will be useful.

coveralls commented 8 years ago

Coverage Status

Coverage increased (+0.2%) to 98.876% when pulling 565c2d41126ceaaf2b9d2c46e19e59a1236adafe on oxinabox:master into 3f75a37fa29f1e5984a3d8685b359f1934d31a53 on jbn:master.

oxinabox commented 8 years ago

I suggest that at this point in Julia's progression maintaining support in new tagged version of packages for 0.3, is more work than it is worth. Since 0.5 is about to be released (it is in rc3). Things that were deprecated in 0.4 and now gone.

coveralls commented 8 years ago

Coverage Status

Coverage increased (+0.2%) to 98.876% when pulling 0fc1be9f73d1ab10b5e29e08c023272a89421588 on oxinabox:master into 3f75a37fa29f1e5984a3d8685b359f1934d31a53 on jbn:master.

jbn commented 8 years ago

@oxinabox I haven't got a chance to look at this yet. I put it on my calendar for Wednesday (along with your #1. Thanks for the PR. Furthermore, I agree, 0.3 is no longer worth it.

oxinabox commented 8 years ago

@jbn No rush. Take your time.
Do take the time to review it well, I'm by no means perfect. Particularly at working with other people's code.

I have my own branch checked out for my use. So I personally am not harmed by waiting.

coveralls commented 8 years ago

Coverage Status

Coverage increased (+0.2%) to 98.876% when pulling f1ead462c9cf6f4a0abce9a174d8a20bc216e6df on oxinabox:master into 3f75a37fa29f1e5984a3d8685b359f1934d31a53 on jbn:master.

jbn commented 8 years ago

LGTM. I'm gonna change some things stylistically and squash the commits. But, thanks!