Closed nickto closed 5 years ago
Merging #24 into master will not change coverage. The diff coverage is
100%
.
@@ Coverage Diff @@
## master #24 +/- ##
=======================================
Coverage 80.86% 80.86%
=======================================
Files 9 9
Lines 277 277
=======================================
Hits 224 224
Misses 53 53
Impacted Files | Coverage Δ | |
---|---|---|
src/sentences/sentence_splitting.jl | 88.13% <100%> (ø) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 4d877dc...e3f8d93. Read the comment docs.
Good catch, do you think it would be better use use \b
rather than \s
?
\b
is word-boundry, where as \s
is white-space.
I think \b
would work better if at the start of the string,
Good catch, do you think it would be better use use
\b
rather than\s
?\b
is word-boundry, where as\s
is white-space. I think\b
would work better if at the start of the string,
Changed it to \b
and added a test that fails when using \s
, thanks!
LGTM, will merge when tests pass
thank!
A sentence ending with an acronym was dot distinguished from an initial followed by a period in the middle of the sentence. E.g., "Adamson is not from USA. They are from Europe" was considered as a single sentence because "USA." was treated as an initial.