search

JuliaText / WordTokenizers.jl

High performance tokenizers for natural language processing and other related tasks
Other
96 stars 25 forks source link

JOSS paper update #34

Closed Ayushk4 closed 5 years ago

Ayushk4 commented 5 years ago

I am opening this PR to JuliaText:josspaper.

codecov-io commented 5 years ago

Codecov Report

Merging #34 into josspaper will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           josspaper      #34   +/-   ##
==========================================
  Coverage      95.74%   95.74%           
==========================================
  Files              5        5           
  Lines             94       94           
==========================================
  Hits              90       90           
  Misses             4        4

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6086657...73a4b2d. Read the comment docs.

Ayushk4 commented 5 years ago

@oxinabox Should I include a section on other software for natural language tokenization available to Julia users?

oxinabox commented 5 years ago

yes. It should also mention TextAnalysis and CorpusLoaders as packages that use WordTokenizers.jl

Ayushk4 commented 5 years ago

It is also being used by https://github.com/chengchingwen/Transformers.jl and BytePairEncoding.jl, should these two also be mentioned?

Ayushk4 commented 5 years ago

@oxinabox Please review and give suggestions on this.

Ayushk4 commented 5 years ago

@oxinabox could you review this PR?

oxinabox commented 5 years ago

Sorry, yes, LGTM