Closed oxinabox closed 4 years ago
Merging #7 into master will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## master #7 +/- ##
=======================================
Coverage 95.74% 95.74%
=======================================
Files 5 5
Lines 94 94
=======================================
Hits 90 90
Misses 4 4
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 882f439...6086657. Read the comment docs.
Merging #7 into master will decrease coverage by
1.33%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #7 +/- ##
==========================================
- Coverage 95.74% 94.41% -1.34%
==========================================
Files 5 10 +5
Lines 94 555 +461
==========================================
+ Hits 90 524 +434
- Misses 4 31 +27
Impacted Files | Coverage Δ | |
---|---|---|
src/words/sedbased.jl | 100% <0%> (ø) |
:arrow_up: |
src/words/tweet_tokenizer.jl | 91.15% <0%> (ø) |
|
src/words/TokTok.jl | 98.43% <0%> (ø) |
|
src/words/fast.jl | 98.14% <0%> (ø) |
|
src/words/reversible_tokenize.jl | 100% <0%> (ø) |
|
src/words/nltk_word.jl | 100% <0%> (ø) |
|
src/words/simple.jl | 100% <0%> (+16.66%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 882f439...53e5d1c. Read the comment docs.
Can I update this with information about TokenBuffer and its lexers to create custom tokenizers? And also other tokenizers - Reversible Tokenizer, Twitter Tokenizers?
yes, please do, and add self as a coauther, and @MikeInnes and @aquatiko too.
@MikeInnes @aquatiko @Ayushk4 as you are all listed as authors, can you review this, and if happy indicate so via github apprroval?
Then we can submit this
Sorry I forgot to action this. Last thing is I think should swap the author order and put @Ayushk4 as first author, as they have done much more on this recently than me.
If I don't hear any objections, I will do this and then will merge and submit
This is blocked by #5 as it says that that is done.