Closed Paethon closed 6 years ago
LGTM Thanks
So tests fail on 1.0 due to TestSetExtensions
which does not support 1.0 due to base removing features it depended on. @oxinabox are you open to removing dependency on that package for now?
I really like it for this. It is particularly useful for the kind of errors we see here.
But yes, lets remove it. it will be easy enough to add back later.
Merging #8 into ox/0.7 will not change coverage. The diff coverage is
98.14%
.
@@ Coverage Diff @@
## ox/0.7 #8 +/- ##
======================================
Coverage 98.8% 98.8%
======================================
Files 4 4
Lines 84 84
======================================
Hits 83 83
Misses 1 1
Impacted Files | Coverage Δ | |
---|---|---|
src/words/simple.jl | 100% <100%> (ø) |
:arrow_up: |
src/words/sedbased.jl | 100% <100%> (ø) |
:arrow_up: |
src/sentences/sentence_splitting.jl | 98.11% <97.95%> (ø) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update f714732...f3733b5. Read the comment docs.
this caught me off-guard, as I didn't realize it was a PR against my PR, so merged them in the wrong order. But with some stuff, I have now fixed that. Thanks.
Seems 1.0 does not work because of TestSetExtensions ...