search

JuliaText / WordTokenizers.jl

High performance tokenizers for natural language processing and other related tasks
Other
96 stars 25 forks source link

Fixes Julia 0.7 deprecation warnings #8

Closed Paethon closed 6 years ago

Paethon commented 6 years ago

Seems 1.0 does not work because of TestSetExtensions ...

oxinabox commented 6 years ago

LGTM Thanks

aviks commented 6 years ago

So tests fail on 1.0 due to TestSetExtensions which does not support 1.0 due to base removing features it depended on. @oxinabox are you open to removing dependency on that package for now?

oxinabox commented 6 years ago

I really like it for this. It is particularly useful for the kind of errors we see here.

But yes, lets remove it. it will be easy enough to add back later.

codecov-io commented 6 years ago

Codecov Report

Merging #8 into ox/0.7 will not change coverage. The diff coverage is 98.14%.

Impacted file tree graph

@@          Coverage Diff           @@
##           ox/0.7      #8   +/-   ##
======================================
  Coverage    98.8%   98.8%           
======================================
  Files           4       4           
  Lines          84      84           
======================================
  Hits           83      83           
  Misses          1       1
Impacted Files Coverage Δ
src/words/simple.jl 100% <100%> (ø) :arrow_up:
src/words/sedbased.jl 100% <100%> (ø) :arrow_up:
src/sentences/sentence_splitting.jl 98.11% <97.95%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f714732...f3733b5. Read the comment docs.

oxinabox commented 6 years ago

this caught me off-guard, as I didn't realize it was a PR against my PR, so merged them in the wrong order. But with some stuff, I have now fixed that. Thanks.