search

JuliaText / WordTokenizers.jl

High performance tokenizers for natural language processing and other related tasks
Other
96 stars 25 forks source link

Fix for 1.0 #9

Closed AShedko closed 6 years ago

AShedko commented 6 years ago

Mostly replace changing input params from 4 args to 3.

aviks commented 6 years ago

Hi could you take the changes from #13, and add your ExtendedTest removal commit on to that. Then do a new PR with those changes.

AShedko commented 6 years ago

Sure.

aviks commented 6 years ago

Actually, this is no longer necessary. Lyndon has merged #13, and made all the changes necessary. Thanks for your contributions!

oxinabox commented 6 years ago

@AShedko sorry, this is on me, there was open PR's that did the same. Which is my fault, if I had have kept up with merging PRs you wouldn't have ended up making one similar to what was already there in #13.