search

JuliaTime / TimeZones.jl

IANA time zone database access for the Julia programming language
Other
86 stars 52 forks source link

Ensure CUSTOM_REGIONS get compiled #307

Closed iamed2 closed 3 years ago

iamed2 commented 3 years ago

Fix #305

Issue was introduced by https://github.com/JuliaTime/TimeZones.jl/commit/07e3c9e8db4c239817653a9758e1fd2a3fb9bb89

regions was being redefined without the utc custom region, which cause the later code compiling the time zones to ignore utc as well.

I did a union! rather than concatenating to avoid compiling anything twice.

codecov-io commented 3 years ago

Codecov Report

Merging #307 (e362b96) into master (a7f73ff) will decrease coverage by 0.32%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #307      +/-   ##
==========================================
- Coverage   93.73%   93.41%   -0.33%     
==========================================
  Files          32       32              
  Lines        1532     1518      -14     
==========================================
- Hits         1436     1418      -18     
- Misses         96      100       +4
Impacted Files Coverage Δ
src/tzdata/build.jl 70.96% <100.00%> (+7.33%) :arrow_up:
src/tzdata/version.jl 80.00% <0.00%> (-11.43%) :arrow_down:
src/winzone/WindowsTimeZoneIDs.jl 70.83% <0.00%> (-8.34%) :arrow_down:
src/tzdata/archive.jl 93.10% <0.00%> (-6.90%) :arrow_down:
src/io.jl 93.65% <0.00%> (-4.77%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a7f73ff...e362b96. Read the comment docs.

mjram0s commented 3 years ago

Some CI jobs failing with

│ [ Info: Extracting 2016j tzdata archive
│ ERROR: LoadError: UndefVarError: artifact_dir not defined

https://travis-ci.com/github/JuliaTime/TimeZones.jl/jobs/441885262#L291