search

JuliaTime / TimeZones.jl

IANA time zone database access for the Julia programming language
Other
86 stars 52 forks source link

Introduce a Shortstring based Name type #324

Closed oxinabox closed 3 years ago

oxinabox commented 3 years ago

A possible partial resolution to #271 Doesn't solve the VariableTimeZone's having a Vector as afield

At the moment tests are failing. That probably is not significiant. just some last things to chase up e.g. with show overloads

oxinabox commented 3 years ago

Tests pass right now. One concern though is that even if we remove the change to the type-parameter of ZonedDateTime (https://github.com/JuliaTime/TimeZones.jl/pull/324#discussion_r610994246) I suspect that this will still utterly break deserialization. I haven't checked yet though.

@omus managed to make Intervals deserialize happily across similar changes, so maybe that can be done here also?

oxinabox commented 3 years ago

I have broken this out into https://github.com/JuliaTime/TimeZones.jl/pull/332 and https://github.com/JuliaTime/TimeZones.jl/pull/330