search

JuliaTime / TimeZones.jl

IANA time zone database access for the Julia programming language
Other
86 stars 52 forks source link

Use ShortStrings for names of both Fixed and Variable timezones #330

Open oxinabox opened 3 years ago

oxinabox commented 3 years ago

This is made on top of #327 it is based on this comment https://github.com/JuliaTime/TimeZones.jl/pull/324#discussion_r613158657

contributes towards #271 but doesn't solve it since VariableTimeZones still have Vector fields, and the ZonedDateTime isnb't parameteric on it's timezone type.

codecov-io commented 3 years ago

Codecov Report

Merging #330 (d2fdec9) into master (faa208e) will increase coverage by 1.08%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #330      +/-   ##
==========================================
+ Coverage   92.51%   93.60%   +1.08%     
==========================================
  Files          32       32              
  Lines        1510     1532      +22     
==========================================
+ Hits         1397     1434      +37     
+ Misses        113       98      -15
Impacted Files Coverage Δ
src/TimeZones.jl 100.00% <ø> (ø)
src/types/variabletimezone.jl 100.00% <ø> (ø)
src/types/fixedtimezone.jl 100.00% <100.00%> (ø)
src/compat.jl 0.00% <0.00%> (-75.00%) :arrow_down:
src/tzdata/build.jl 63.63% <0.00%> (-4.55%) :arrow_down:
src/local.jl 88.15% <0.00%> (-0.74%) :arrow_down:
src/tzdata/archive.jl 100.00% <0.00%> (ø)
src/tzdata/compile.jl 95.50% <0.00%> (+0.32%) :arrow_up:
src/build.jl 100.00% <0.00%> (+16.66%) :arrow_up:
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update faa208e...d2fdec9. Read the comment docs.