Closed morris25 closed 3 years ago
Can you post the full deprecation messages for the record?
Unfortunately Downloads.jl only works on julia v1.3 or greater. I'm not sure how to get packages to resolve on 1.0.
We should be able to get this working by doing:
if VERSION >= v"1.3"
using Downloads: download
else
using Base: download
end
This seems to be due to a couple of version dependent deprecations to the locations of
@artifact_str
anddownload
causing failures when trying to build TimeZones with depwarn set to error.
You may also need to change this line: https://github.com/JuliaTime/TimeZones.jl/blob/781e59a2075a24651d6ae70491c4b87392640e51/src/compat.jl#L48
Unfortunately Downloads.jl only works on julia v1.3 or greater. I'm not sure how to get packages to resolve on 1.0.
We should be able to get this working by doing:
if VERSION >= v"1.3" using Downloads: download else using Base: download end
The problem is that including Downloads in the Project.toml results in resolution failures in julia 1.0
(TimeZones) pkg> build
Updating registry at `~/.julia/registries/General`
Updating git-repo `https://github.com/JuliaRegistries/General.git`
Updating registry at `~/.julia/registries/Invenia`
Updating git-repo `git@gitlab.invenia.ca:invenia/PackageRegistry.git`
Resolving package versions...
ERROR: Unsatisfiable requirements detected for package LibCURL [b27032c2]:
LibCURL [b27032c2] log:
├─possible versions are: [0.3.0-0.3.2, 0.4.0-0.4.1, 0.5.0-0.5.2, 0.6.0-0.6.3] or uninstalled
├─restricted by compatibility requirements with Downloads [f43a241f] to versions: 0.6.0-0.6.3
│ └─Downloads [f43a241f] log:
│ ├─possible versions are: [0.1.0, 0.2.0, 1.0.0, 1.1.0-1.1.1, 1.2.0, 1.3.0, 1.4.0-1.4.1, 1.5.0] or uninstalled
│ └─restricted to versions * by an explicit requirement, leaving only versions [0.1.0, 0.2.0, 1.0.0, 1.1.0-1.1.1, 1.2.0, 1.3.0, 1.4.0-1.4.1, 1.5.0]
└─restricted by julia compatibility requirements to versions: [0.3.0-0.3.2, 0.4.0-0.4.1, 0.5.0-0.5.2] or uninstalled — no versions left
I'm not sure if there is a way to resolve the dependencies without updating a bunch of other packages.
I'm not sure if there is a way to resolve the dependencies without updating a bunch of other packages.
Posted solution ideas here: https://github.com/JuliaTime/TimeZones.jl/pull/339#discussion_r629505488
Merging #339 (c34367b) into master (781e59a) will increase coverage by
0.00%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## master #339 +/- ##
=======================================
Coverage 93.59% 93.60%
=======================================
Files 32 32
Lines 1531 1532 +1
=======================================
+ Hits 1433 1434 +1
Misses 98 98
Impacted Files | Coverage Δ | |
---|---|---|
src/compat.jl | 0.00% <ø> (ø) |
|
src/tzdata/build.jl | 63.63% <ø> (ø) |
|
src/tzdata/download.jl | 96.00% <100.00%> (+0.08%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 781e59a...c34367b. Read the comment docs.
When running jobs to find deprecations on our CI on julia 1.6, our jobs are failing with errors like:
This error shows up only in our deprecations jobs and started happening directly after we switched the jobs to julia 1.6. When packages are built, TimeZones claims to have built successfully but then fails when used.
This seems to be due to a couple of version dependent deprecations to the locations of
@artifact_str
anddownload
causing failures when trying to build TimeZones withdepwarn
set toerror
.Deprecation failures when run directly:
Unfortunately Downloads.jl only works on julia v1.3 or greater. I'm not sure how to get packages to resolve on 1.0.