search

JuliaTime / TimeZones.jl

IANA time zone database access for the Julia programming language
Other
86 stars 52 forks source link

Update to Unicode CLDR 39 / Use specified CLDR version #351

Closed omus closed 3 years ago

omus commented 3 years ago

Fixes https://github.com/JuliaTime/TimeZones.jl/issues/350. During updating the CLDR release I noticed we were still embedding the Windows translation files were still begin embedded since https://github.com/JuliaTime/TimeZones.jl/pull/49. Since the issue with throttling had to do with downloading directly from unicode.org we should no longer have this problem since we're downloading from GitHub.

codecov-commenter commented 3 years ago

Codecov Report

Merging #351 (98693e1) into master (71178fe) will decrease coverage by 0.42%. The diff coverage is 50.00%.

:exclamation: Current head 98693e1 differs from pull request most recent head 09678e2. Consider uploading reports for the commit 09678e2 to get more accurate results Impacted file tree graph

@@            Coverage Diff             @@
##           master     #351      +/-   ##
==========================================
- Coverage   93.60%   93.18%   -0.43%     
==========================================
  Files          32       32              
  Lines        1532     1525       -7     
==========================================
- Hits         1434     1421      -13     
- Misses         98      104       +6
Impacted Files Coverage Δ
src/winzone/WindowsTimeZoneIDs.jl 56.52% <50.00%> (-22.65%) :arrow_down:
src/build.jl 83.33% <0.00%> (-16.67%) :arrow_down:
src/local.jl 88.00% <0.00%> (-0.16%) :arrow_down:
src/tzdata/archive.jl 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 71178fe...09678e2. Read the comment docs.