oxinabox
commented
2 years ago 1.3 tests are failing as in julia 1.3 JULIA_NUMTHREADS enviroment variable was only way to set number of threads.
But tests use julia -t instead.
I will fix on monday
Closed oxinabox closed 2 years ago
oxinabox
commented
2 years ago 1.3 tests are failing as in julia 1.3 JULIA_NUMTHREADS enviroment variable was only way to set number of threads.
But tests use julia -t instead.
I will fix on monday
oxinabox
commented
2 years ago I'd be okay with setting the minimum to 1.3.2 to clear out this:
Turns out there is no 1.3.2. The last 1.3 release was 1.3.1, so that code is needed to support 1.3 at all.
codecov-commenter
commented
2 years ago Merging #361 (fcf6e78) into master (22a32d4) will increase coverage by
0.97%. The diff coverage is50.00%.
@@ Coverage Diff @@
## master #361 +/- ##
==========================================
+ Coverage 93.30% 94.27% +0.97%
==========================================
Files 32 32
Lines 1613 1607 -6
==========================================
+ Hits 1505 1515 +10
+ Misses 108 92 -16 | Impacted Files | Coverage Δ | |
|---|---|---|
| src/types/timezone.jl | 94.28% <ø> (+2.61%) |
:arrow_up: |
| src/tzdata/download.jl | 96.15% <ø> (-0.08%) |
:arrow_down: |
| src/tzdata/build.jl | 68.75% <46.66%> (+5.70%) |
:arrow_up: |
| src/winzone/WindowsTimeZoneIDs.jl | 100.00% <100.00%> (+40.90%) |
:arrow_up: |
| src/tzdata/version.jl | 81.57% <0.00%> (-10.53%) |
:arrow_down: |
| src/tzdata/archive.jl | 100.00% <0.00%> (ø) |
|
| src/local.jl | 88.88% <0.00%> (+0.13%) |
:arrow_up: |
| src/build.jl | 100.00% <0.00%> (+16.66%) |
:arrow_up: |
| ... and 1 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 22a32d4...fcf6e78. Read the comment docs.
omus
commented
2 years ago
As discussed in #354 raising min version to 1.3 will let use InlineStrings.jl