omus commented 2 years ago

Replaces: https://github.com/JuliaTime/TimeZones.jl/pull/328

When set to true, GitHub cancels all in-progress jobs if any matrix job fails. Default: true

https://docs.github.com/en/actions/learn-github-actions/workflow-syntax-for-github-actions#jobsjob_idstrategyfail-fast

By setting fail-fast: false on the benchmark job then a failure there does not cancel the other in-progress jobs but other jobs with fail-fast: true can cause the benchmark to be cancelled.

omus commented 2 years ago

My issue was that it's fail-fast and not fast-fail 🤦

codecov-commenter commented 2 years ago

Codecov Report

Merging #370 (aba679a) into master (6bea555) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #370   +/-   ##
=======================================
  Coverage   93.75%   93.75%           
=======================================
  Files          31       31           
  Lines        1554     1554           
=======================================
  Hits         1457     1457           
  Misses         97       97

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6bea555...aba679a. Read the comment docs.

JuliaTime / TimeZones.jl

Benchmark failures should not cancel other jobs #370

Codecov Report