search

JuliaTime / TimeZones.jl

IANA time zone database access for the Julia programming language
Other
87 stars 52 forks source link

Make Windows directory during package build #372

Closed omus closed 2 years ago

omus commented 2 years ago

~Attempting to address #371~

Fixes #371

codecov-commenter commented 2 years ago

Codecov Report

Merging #372 (fc79408) into master (1773b47) will increase coverage by 0.00%. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #372   +/-   ##
=======================================
  Coverage   93.88%   93.89%           
=======================================
  Files          30       30           
  Lines        1538     1540    +2     
=======================================
+ Hits         1444     1446    +2     
  Misses         94       94
Impacted Files Coverage Δ
src/winzone/WindowsTimeZoneIDs.jl 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1773b47...fc79408. Read the comment docs.

Felix-Gauthier commented 2 years ago

With TimeZones#cv/win-mkdir I was able to relocate the example app from the original issue on another Windows machine and get it to run ! 🎉

I'll try again with my CLI app, but I'm confident this addressed the problem. 👍

Felix-Gauthier commented 2 years ago

Tested with a more complex app -- looks good!

Thanks for the help, it's appreciated.

omus commented 2 years ago

Perfect. I'll merge this and make a new release