search

JuliaTime / TimeZones.jl

IANA time zone database access for the Julia programming language
Other
87 stars 52 forks source link

Switch to using TZJFile serialization format #385

Closed omus closed 2 years ago

omus commented 2 years ago

Utilizes the changes introduced in #380. We should definitely pair this with scratch spaces like in #384

codecov-commenter commented 2 years ago

Codecov Report

Merging #385 (4685508) into master (d83abbc) will not change coverage. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #385   +/-   ##
=======================================
  Coverage   95.12%   95.12%           
=======================================
  Files          35       35           
  Lines        1743     1743           
=======================================
  Hits         1658     1658           
  Misses         85       85
Impacted Files Coverage Δ
src/TimeZones.jl 100.00% <ø> (ø)
src/types/timezone.jl 97.14% <100.00%> (ø)
src/tzdata/compile.jl 95.43% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d83abbc...4685508. Read the comment docs.

ViralBShah commented 2 years ago

Turns out to be quite a yak shave

omus commented 2 years ago

In my opinion I think we should merge this prior to #384. Mainly because this avoids every populating the scratch directory with the old serialized files.