JuliaTime / TimeZones.jl

IANA time zone database access for the Julia programming language
Other
86 stars 51 forks source link

Modify show for FixedTimeZone #412

Closed omus closed 1 year ago

omus commented 1 year ago

In https://github.com/JuliaStrings/InlineStrings.jl/pull/52 (InlineStrings@1.3.0) the repr method for InlineString now shows type information (👍 ). For the show method for FixedTimeZone this information isn't required as all strings are convered to an InlineString. To keep the output of show concise we'll just show a simple string instead of including the type information.

omus commented 1 year ago

First CI run hit this issue on Julia 1.9.0-DEV.1757 Linux x64:

 [1834] signal (11.1): Segmentation fault
in expression starting at /home/runner/work/TimeZones.jl/TimeZones.jl/test/thread-safety.jl:1
do_apply at /cache/build/default-amdci5-1/julialang/julia-master/src/builtins.c:603
#sprint#486 at ./strings/io.jl:114
sprint at ./strings/io.jl:107 [inlined]
join at ./strings/io.jl:353 [inlined]
timezone_names at /home/runner/work/TimeZones.jl/TimeZones.jl/src/discovery.jl:17
#183 at ./generator.jl:0 [inlined]
iterate at ./generator.jl:47 [inlined]
iterate at ./iterators.jl:1195 [inlined]
iterate at ./iterators.jl:1192 [inlined]
iterate at ./iterators.jl:1192 [inlined]
grow_to! at ./array.jl:886
grow_to! at ./array.jl:884
unknown function (ip: 0x7fbdfcce940d)
_jl_invoke at /cache/build/default-amdci5-1/julialang/julia-master/src/gf.c:2450 [inlined]
ijl_apply_generic at /cache/build/default-amdci5-1/julialang/julia-master/src/gf.c:2632
grow_to! at ./array.jl:859
_collect at ./array.jl:759 [inlined]
collect at ./array.jl:707 [inlined]
cycle_zdts at /home/runner/work/TimeZones.jl/TimeZones.jl/test/thread-safety.jl:11 [inlined]
macro expansion at /home/runner/work/TimeZones.jl/TimeZones.jl/test/thread-safety.jl:30 [inlined]
#186 at ./threadingconstructs.jl:340
unknown function (ip: 0x7fbdfcce1b2f)
_jl_invoke at /cache/build/default-amdci5-1/julialang/julia-master/src/gf.c:2450 [inlined]
ijl_apply_generic at /cache/build/default-amdci5-1/julialang/julia-master/src/gf.c:2632
jl_apply at /cache/build/default-amdci5-1/julialang/julia-master/src/julia.h:1867 [inlined]
start_task at /cache/build/default-amdci5-1/julialang/julia-master/src/task.c:1087
Allocations: 66930496 (Pool: 66887700; Big: 42796); GC: 56
omus commented 1 year ago

I'm going to leave on fast-fail: false as this repo isn't seeing that much CI activity and it's useful for identifying the source of some issues.