search

JuliaTime / TimeZones.jl

IANA time zone database access for the Julia programming language
Other
86 stars 51 forks source link

CI: test both with and without threading #415

Closed DilumAluthge closed 2 months ago

codecov-commenter commented 1 year ago

Codecov Report

Merging #415 (65eb312) into master (147c8c2) will not change coverage. The diff coverage is n/a.

:exclamation: Current head 65eb312 differs from pull request most recent head d1a5e0d. Consider uploading reports for the commit d1a5e0d to get more accurate results

@@           Coverage Diff           @@
##           master     #415   +/-   ##
=======================================
  Coverage   95.45%   95.45%           
=======================================
  Files          36       36           
  Lines        1760     1760           
=======================================
  Hits         1680     1680           
  Misses         80       80

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

omus commented 1 year ago

Any motivation behind this?

DilumAluthge commented 1 year ago

Yeah, I have a hypothesis that the segfaults that we're seeing on Julia nightly only happen when threading is enabled.

omus commented 2 months ago

We may want to start testing with threads yet but the original reason for this is no longer happening.