search

JuliaTime / TimeZones.jl

IANA time zone database access for the Julia programming language
Other
86 stars 51 forks source link

Show `FixedTimeZone` name as a regular string #432

Closed omus closed 1 year ago

omus commented 1 year ago

The change from https://github.com/JuliaStrings/InlineStrings.jl/pull/52 changed how show works for InlineStrings.String15 which broke the tests here. I've updated how we show FixedTimeZone so that the name always prints as a regular String. This works fine for constructing a FixedTimeZone and is more terse this seems like a reasonable change.

omus commented 1 year ago

I did already attempt to fix this in: https://github.com/JuliaTime/TimeZones.jl/pull/412. There must have been another change to string which broke the original fix

codecov-commenter commented 1 year ago

Codecov Report

Merging #432 (2300429) into master (f8f39b3) will decrease coverage by 1.25%. The diff coverage is 100.00%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master     #432      +/-   ##
==========================================
- Coverage   95.45%   94.21%   -1.25%     
==========================================
  Files          36       38       +2     
  Lines        1760     1762       +2     
==========================================
- Hits         1680     1660      -20     
- Misses         80      102      +22
Impacted Files Coverage Δ
src/io.jl 100.00% <100.00%> (ø)

... and 10 files with indirect coverage changes

omus commented 1 year ago

The nightly documentation failure is something else. Will tackle that separately