JuliaTime / TimeZones.jl

IANA time zone database access for the Julia programming language
Other
87 stars 53 forks source link

Upgrade Documenter to 0.27 #436

Closed mortenpi closed 1 year ago

mortenpi commented 1 year ago

The documentation has not deployed for nearly 3 years. It looks like it tries to use some TRAVIS_* variables, because the ancient Documenter version that it tries to use probably predated full GitHub Actions support. I hope that bumping Documenter is enough (fix #397).

I checked the built docs manually, and I didn't notice any major issues with the upgrade.

The only thing is that it looks like the doctests are pretty broken in general. I don't quite understand why the current CI is passing, but I assume that it will start failing now. But there have also been changes in Documenter, so it's probably a multitude of factors here.

A few changes in general:

mortenpi commented 1 year ago

I would appreciate if someone could approve the CI run so that I could see if the changes are working or not.

omus commented 1 year ago

Thanks @mortenpi! I appreciate the PR

codecov-commenter commented 1 year ago

Codecov Report

Merging #436 (472c6f0) into master (3bdc66d) will not change coverage. The diff coverage is n/a.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##           master     #436   +/-   ##
=======================================
  Coverage   95.57%   95.57%           
=======================================
  Files          38       38           
  Lines        1762     1762           
=======================================
  Hits         1684     1684           
  Misses         78       78