search

JuliaTime / TimeZones.jl

IANA time zone database access for the Julia programming language
Other
87 stars 53 forks source link

move RecipesBase support to an extension on 1.9+ #446

Closed palday closed 1 year ago

palday commented 1 year ago

This uses the method in the Pkg docs to continue support for Julia < 1.9.

On 1.9, this shaves about 100ms off of using TimeZones for me.

palday commented 1 year ago

For the Benchmark CI -- it looks like the environment isn't re-resolved when comparing to origin/HEAD and this causes errors. xref https://github.com/JuliaCI/PkgBenchmark.jl/issues/137

codecov-commenter commented 1 year ago

Codecov Report

Merging #446 (f9fb85a) into master (77c9c04) will increase coverage by 0.05%. The diff coverage is n/a.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master     #446      +/-   ##
==========================================
+ Coverage   92.66%   92.72%   +0.05%     
==========================================
  Files          40       40              
  Lines        1841     1841              
==========================================
+ Hits         1706     1707       +1     
+ Misses        135      134       -1
Files Changed Coverage Δ
ext/TimeZonesRecipesBaseExt.jl 88.88% <ø> (ø)
src/TimeZones.jl 92.85% <ø> (ø)

... and 1 file with indirect coverage changes