search

JuliaTime / TimeZones.jl

IANA time zone database access for the Julia programming language
Other
86 stars 51 forks source link

Restore RecipesBase dep to fix 1.6 #461

Closed ericphanson closed 1 month ago

ericphanson commented 1 month ago

xref https://github.com/JuliaTime/TimeZones.jl/pull/459#issuecomment-2123418212

ericphanson commented 1 month ago

I'm not 100% sure, but it seems to have been there pre-#459 so I think it would make sense to leave it to keep this as a minimal revert of the broken bit

omus commented 1 month ago

My bad. It's way too easy to miss this. Why can't I have the CI fail for TimeZones itself?

codecov-commenter commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 92.07%. Comparing base (2bc8f50) to head (c46befb). Report is 5 commits behind head on master.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #461 +/- ## ========================================== - Coverage 92.79% 92.07% -0.72% ========================================== Files 39 39 Lines 1818 1830 +12 ========================================== - Hits 1687 1685 -2 - Misses 131 145 +14 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

omus commented 1 month ago

I've made another PR to add a CI check to ensure this doesn't happen again: https://github.com/JuliaTime/TimeZones.jl/pull/462