search

JuliaTime / TimeZones.jl

IANA time zone database access for the Julia programming language
Other
86 stars 51 forks source link

Ensure we don't break weakdeps #462

Closed omus closed 1 month ago

omus commented 1 month ago

None of the CI checks currently in place ensure that we maintain compatibility for older versions of Julia for [weakdeps]. This adds a new GHA job to ensure these problems are caught before they make it into a release.

This should prevent this mistake from happening again: https://github.com/JuliaTime/TimeZones.jl/pull/459#issuecomment-2123418212

omus commented 1 month ago

Appears that I need to use Pkg.add and cannot use Pkg.develop in order to catch this failure

omus commented 1 month ago

Example of the job reproducing the failure: https://github.com/JuliaTime/TimeZones.jl/actions/runs/9184914310/job/25258000384

omus commented 1 month ago

Looks like this check is working