Pw/explaintrussjson - Githubissues

JuliaTopOpt / TopOpt.jl

A package for binary and continuous, single and multi-material, truss and continuum, 2D and 3D topology optimization on unstructured meshes using automatic differentiation in Julia.

https://juliatopopt.github.io/TopOpt.jl/

Other

181 stars 30 forks source link

Pw/explaintrussjson #148

Closed pitipatw closed 1 year ago

pitipatw commented 1 year ago

Summary

A short summary of the changes in this PR.

Highlights:

JSON file explanation
Remove lines that relate to visualization

What type of change is this?

[ ] Bug fix in a backwards-compatible manner.
[ ] New feature in a backwards-compatible manner.
[ ] Breaking change: bug fix or new feature that involve incompatible API changes.
[x] Other (e.g. doc update, configuration, etc)

Checklist

[ ] I ran all tests on my computer and it's all green (i.e. ] test).
[ ] I have added tests that prove my fix is effective or that my feature works.
[x] I have added necessary documentation (if appropriate)

pitipatw commented 1 year ago

I commented those lines out.

mohamed82008 commented 1 year ago

I merged master into this. You will need to do git pull from your local branch before you push other changes to this PR.

pitipatw commented 1 year ago

I merged master into this. You will need to do git pull from your local branch before you push other changes to this PR.

You mean pull the master branch to my local branch then create a new PR from the branch?

mohamed82008 commented 1 year ago

No just pull from the pw/explaintrussjson branch on GitHub (which I modified) to your local pw/explaintrussjson branch (to sync them) before you make further changes locally and then push them to the GitHub branch which will update this PR.

mohamed82008 commented 1 year ago

If that doesn't make sense, we can discuss it on a call.

yijiangh commented 1 year ago

Close since the doc is included in https://github.com/JuliaTopOpt/TopOpt.jl/pull/152/commits/c01a05e11554a82d14df99aa47a716fc28002146 as a part of #152 .