Closed john-waczak closed 9 months ago
Hi @john-waczak, thanks very much for this! Reformatting has been a bit of a pain point, so if this see resolves the issue should also have better compatibility with other models from MLJ
. Will just wait for tests and then merge, thanks a lot!
Awesome, I've really enjoyed using the package so far. Thank you for the hard work!
This pull request adds support for models from
DecisionTree.jl
. Specifically, I have tested:DecisionTreeRegressor
RandomForestRegressor
DecisionTreeClassifier
RandomForestClassifier
To get this to work, I had to move the calls toMMI.reformat(conf_model.model, ...)
to inside thefit
andpredict
methods. CallingMMI.reformat()
on data before passing tofit
andpredict
causes these models to fail, perhaps due to this issue.