Adding support for DecisionTree.jl models.

JuliaTrustworthyAI / ConformalPrediction.jl

Predictive Uncertainty Quantification through Conformal Prediction for Machine Learning models trained in MLJ.

https://juliatrustworthyai.github.io/ConformalPrediction.jl/

MIT License

135 stars 12 forks source link

Adding support for DecisionTree.jl models. #108

Closed john-waczak closed 9 months ago

john-waczak commented 9 months ago

This pull request adds support for models from DecisionTree.jl. Specifically, I have tested:

DecisionTreeRegressor
RandomForestRegressor
DecisionTreeClassifier
RandomForestClassifier To get this to work, I had to move the calls to MMI.reformat(conf_model.model, ...) to inside the fit and predict methods. Calling MMI.reformat() on data before passing to fit and predict causes these models to fail, perhaps due to this issue.

pat-alt commented 9 months ago

Hi @john-waczak, thanks very much for this! Reformatting has been a bit of a pain point, so if this see resolves the issue should also have better compatibility with other models from MLJ. Will just wait for tests and then merge, thanks a lot!

john-waczak commented 9 months ago

Awesome, I've really enjoyed using the package so far. Thank you for the hard work!