Closed MojiFarmanbar closed 5 months ago
I think this branch was out-of-date? Have now merged updates from main
Notes from chat:
Model<:Supervised
, use more restrictive instead (e.g. MLJLinearModels.QuantileRegressor
)."Union type for quantile models."
const QuantileModel = Union{MLJModels.QuantileRegressor, MLJ.QuantileClassifier, ScikitLearn.QuantileTrees}
"Constructor for `ConformalQuantileRegressor`."
mutable struct ConformalQuantileRegressor{Model<:QuantileModel} <: ConformalInterval
ArgumentError
is thrown if not QuantileModel
and skip rest of workflow, else as always.@pat-alt , I have adjusted based on above checklist, please review and check the PR. at the moment, it is only for one model (QuantileRegression). I will extend it to more models in another PR.
Hey @MojiFarmanbar, I'm a bit confused that when I'm trying to add a review it shows so many files changed. Have just removed the merge conflicts so that we can see if tests pass. Once they pass, I'm happy to merge this based on what we discussed and contingent on the check list items being done (as you mentioned).
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 72.34%. Comparing base (
c4ef89a
) to head (9293cc8
). Report is 2 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Hi @MojiFarmanbar, only missing thing here is the error in docs. Other errors are unrelated to this PR, will have a crack at that next week hopefully
This is a draft pull request