search

JuliaTrustworthyAI / CounterfactualExplanations.jl

A package for Counterfactual Explanations and Algorithmic Recourse in Julia.
https://www.taija.org/CounterfactualExplanations.jl/
MIT License
119 stars 7 forks source link

457 constrained optimization for scms #464

Closed JorgeLuizFranco closed 1 month ago

JorgeLuizFranco commented 2 months ago

Closes #457

pat-alt commented 1 month ago

@JorgeLuizFranco I think that once tests pass and you've updated the CHANGELOG.md, this can be merged.

What's still missing then to make the project complete, is the following:

I'll add details to the issues.

JorgeLuizFranco commented 1 month ago

@JorgeLuizFranco I think that once tests pass and you've updated the CHANGELOG.md, this can be merged.

What's still missing then to make the project complete, is the following:

I'll add details to the issues.

So, should I open new PRs for these right, @pat-alt ?

pat-alt commented 1 month ago

@JorgeLuizFranco I think that once tests pass and you've updated the CHANGELOG.md, this can be merged. What's still missing then to make the project complete, is the following:

I'll add details to the issues.

So, should I open new PRs for these right, @pat-alt ?

You can link branches to the new issues I've opened. Do you know how to do that?

JorgeLuizFranco commented 1 month ago

@JorgeLuizFranco I think that once tests pass and you've updated the CHANGELOG.md, this can be merged. What's still missing then to make the project complete, is the following:

I'll add details to the issues.

So, should I open new PRs for these right, @pat-alt ?

You can link branches to the new issues I've opened. Do you know how to do that?

Sure, Patrick. This was indeed what I have done with the previous issues. Just asked because maybe your idea could be to continue in this branch. Now I understood 🙌

pat-alt commented 1 month ago

Thanks for all your efforts @JorgeLuizFranco, I'll go ahead and merge this 🥳