Closed pasq-cat closed 2 months ago
i have been trying to cross check the various branches and i think that there is a change now that has to be implemented.
I will work on the docs in a pull request separate from the coding part if you don't mind.
train
method now returnsla, optimiser_state, history
wherela
is theLaplace
object. This way, the object does not need to be stored as a field of the struct and the problem withupdate
is avoided.(la::AbstractLaplace)(X::AbstractArray)
now simply calls the underlying neural network on data. In other words, it returns the generic predictions, not LA predictions.fitresult
method was adjusted also for the classification case.Now that tests are passing, there are a few more things to do (possibly in a new issue + PR) if you like.
src/mlj_flux.jl
can be streamlined further (e.g. do we actually still need to overloadMLJFlux.build
)?For now, feel free to to focus on the other PR, just ping me and @MojiFarmanbar when you come back to this one. I need to move on to other things for now.
Originally posted by @pat-alt in https://github.com/JuliaTrustworthyAI/LaplaceRedux.jl/issues/92#issuecomment-2200204269