JuliaTrustworthyAI / LaplaceRedux.jl

Effortless Bayesian Deep Learning through Laplace Approximation for Flux.jl neural networks.
https://www.taija.org/LaplaceRedux.jl/
MIT License
39 stars 3 forks source link

101 remaining issue on the mljinterface #103

Closed pasq-cat closed 2 months ago

pasq-cat commented 2 months ago

changed predict and mlj_flux_interface so that they work together well. part of gsoc 24

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.47%. Comparing base (7d70d2c) to head (240b192).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #103 +/- ## ========================================== + Coverage 95.27% 96.47% +1.19% ========================================== Files 21 21 Lines 593 595 +2 ========================================== + Hits 565 574 +9 + Misses 28 21 -7 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

pasq-cat commented 2 months ago

@MojiFarmanbar @pat-alt it seems to work now. maybe i made some mistake in the previous commits. Anyway i could only partially improve the predict method because predict does not accept iterators so it doesn't work directly with collect(eachrow(Xnew))

should be ok to merge.