Closed pat-alt closed 4 weeks ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 96.48%. Comparing base (
78c846e
) to head (9873c55
). Report is 5 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
shoudln't the same be done in
function MLJFlux.predict(model::LaplaceRegression, fitresult, Xnew)
?
Yes, I've done that
shoudln't the same be done in
function MLJFlux.predict(model::LaplaceRegression, fitresult, Xnew)
?Yes, I've done that
btw i was sure that laplace accepted vectors as input. has anything been changed or i was wrong the whole time? the documentation says abstractarray but i distinctly remember this requirement....
shoudln't the same be done in
function MLJFlux.predict(model::LaplaceRegression, fitresult, Xnew)
?Yes, I've done that
btw i was sure that laplace accepted vectors as input. has anything been changed or i was wrong the whole time? the documentation says abstractarray but i distinctly remember this requirement....
hmm not sure where you say this https://juliatrustworthyai.github.io/LaplaceRedux.jl/stable/reference/#LaplaceRedux.predict-Tuple{LaplaceRedux.AbstractLaplace,%20AbstractArray}
shoudln't the same be done in
function MLJFlux.predict(model::LaplaceRegression, fitresult, Xnew)
?Yes, I've done that
btw i was sure that laplace accepted vectors as input. has anything been changed or i was wrong the whole time? the documentation says abstractarray but i distinctly remember this requirement....
hmm not sure where you say this https://juliatrustworthyai.github.io/LaplaceRedux.jl/stable/reference/#LaplaceRedux.predict-Tuple{LaplaceRedux.AbstractLaplace,%20AbstractArray}
i know i know, must have been something that i have misunderstood in the first days, mah
@pasq-cat I think we should indeed just go with the direct MLJ interface #121 but for now I would still merge this cause it addresses the compute times.