JuliaTrustworthyAI / LaplaceRedux.jl

Effortless Bayesian Deep Learning through Laplace Approximation for Flux.jl neural networks.
https://www.taija.org/LaplaceRedux.jl/
MIT License
39 stars 3 forks source link

new glm_predictive_distribution and corresponding changes in LaplaceRedux.predict #99

Closed pasq-cat closed 2 months ago

pasq-cat commented 3 months ago

this pull request add the following things:

pasq-cat commented 2 months ago

@pat-alt brah! what happened? i only changed a number!

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 96.87500% with 1 line in your changes missing coverage. Please review.

Project coverage is 95.27%. Comparing base (3e1531d) to head (b59fc14).

Files Patch % Lines
src/baselaplace/predicting.jl 96.87% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #99 +/- ## ========================================== + Coverage 94.95% 95.27% +0.32% ========================================== Files 21 21 Lines 575 593 +18 ========================================== + Hits 546 565 +19 + Misses 29 28 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

pasq-cat commented 2 months ago

@pat-alt @MojiFarmanbar i tried to cover all the new cases but since there are a lot of ifs i had to add multiple tests.

pat-alt commented 2 months ago

@MojiFarmanbar do you want to have a quick look as well or should we merge this?

MojiFarmanbar commented 2 months ago

@pat-alt i had a quick look, if you approve it then i would say let's merge it.