PolyData - Githubissues

JuliaVTK / ReadVTK.jl

Julia package for reading VTK XML files

https://juliavtk.github.io/ReadVTK.jl

MIT License

30 stars 9 forks source link

PolyData #11

Closed OndrejKincl closed 2 years ago

OndrejKincl commented 2 years ago

As requested, I send a very simple modification which allows to handle polydata and a test which shows that it works.

Disclaimers:

I did not know what to set as n_cells. Polydata does not really have cells. I set it to zero.
Be warned that I am a mathematician. Not a programmer.
Polydata also allow lines and triangle patches which I did not test.

Closes #10

OndrejKincl commented 2 years ago

I made several more changes:

I set n_cells for PolyData to be sum of vertices + lines + polygons
I realized that cell information cannot be obtained using the get_cells function. This is because PolyData can have cells of different kinds and have no attribute "Types". So I made separate struct for them, which I called VTKPrimitives and a function get_primitives to extract them. In case you don't like it, I can return these changes.
I added another test for PolyData
I updated the README

coveralls commented 2 years ago

Coverage decreased (-0.9%) to 92.017% when pulling 838f73aaca3c13543ee182f53ee3371d153f61d9 on OndrejKincl:polydata into f95fea3fb096487c5ac333c2c6ca835ae408c665 on trixi-framework:main.

OndrejKincl commented 2 years ago

Thank you very much for being a reviewer. I believe it is not easy.