JuliaVTK / ReadVTK.jl

Julia package for reading VTK XML files
https://juliavtk.github.io/ReadVTK.jl
MIT License
30 stars 9 forks source link

Fix for connectivity offset from WriteVTK #23

Closed Matthew-Whisenant closed 1 year ago

Matthew-Whisenant commented 1 year ago

Increment connectivity in get_cells by one in order to match WriteVTK output. Had to increment the manual connectivity test case by one as well.

This is a partial fix for #21.

Matthew-Whisenant commented 1 year ago

Ah well. Clearly something with my whitespace formatting is still auto formatting. I'll leave this one up and try to figure out how I can eliminate that in the future.

coveralls commented 1 year ago

Coverage Status

Coverage: 93.708%. Remained the same when pulling a2a10ddc762c04e3e7db6b5fabe9ba265e6935a4 on Matthew-Whisenant:main into 8ceeb4f9b556fee6066aa170074533dad9f50a92 on trixi-framework:main.

sloede commented 1 year ago

The Windows tests are failing due to a know (but intermittent) issue with decompression, thus I'll go forward and merge this manually.