search

JuliaVTK / ReadVTK.jl

Julia package for reading VTK XML files
https://juliavtk.github.io/ReadVTK.jl
MIT License
30 stars 9 forks source link

Added ParaView file output read ability. #28

Closed Matthew-Whisenant closed 1 year ago

Matthew-Whisenant commented 1 year ago

This PR adds the lines needed to read the slightly different ParaView output format of VTKs. The base64decode needed another filter for the raw data. ParaView also doesn't give the "NumberOfComponents" tag to scalars, so that line was changed per issue #20

Also added some tests that read to files with identical data, but one was read and then re-output by ParaView. I've submitted a PR for that test file in the examples repo.

Lastly the "convert_VTKCells_to_MeshCells" does what it says. It can be named something better, but at least its here to show how to convert between VTKCells style to MeshCells.

I realized after the first commit here, that this function probably should have been a separate PR. Sorry about that, still learning the ropes. I can redo everything if necessary.

Please let me know any concerns or suggestions you have.

Matthew-Whisenant commented 1 year ago

After this both #20 and #21 can probably be closed.

Forgot to mention that all the tests passed when I loaded the ParaView file from a local directory. It will probably fail until this is accepted https://github.com/JuliaVTK/ReadVTK_examples/pull/1

sloede commented 1 year ago

Why was this closed when I merged #26? @Matthew-Whisenant please feel free to reopen this, this closing it was not my intent.

Matthew-Whisenant commented 1 year ago

I don't exactly see how to reopen. Maybe cause the branch already merged? I can reopen on the main branch. Should we move the conversation to that PR or continue on this one?

sloede commented 1 year ago

Ah, right. If you press the Edit button above next to the PR title, you should be able to change the merge target to main. Then, you should be able to reopen this PR

Matthew-Whisenant commented 1 year ago

It seems like I can't do this. Here is forum discussing it..

I still need to add the documentation stuff so I'll just create a new PR over the weekend when I have time.

I have also clicked the "Allow edits by maintainers" if that, for some reason, allows you to reopen or do something. If it does work I'll just update this PR.

sloede commented 1 year ago

I have also clicked the "Allow edits by maintainers" if that, for some reason, allows you to reopen or do something. If it does work I'll just update this PR.

Sorry, thus didn't to the trick. You will have to recreate a new PR.