Closed Matthew-Whisenant closed 1 year ago
I guess range
was different for LTS Julia 1.6 so I updated so that it works. Strange that it worked on Julia 1 but failed on Julia 1.6. They must have reverted back because it didn't fail on 1.85. Regardless, I fixed so it works an all version. The fix was kinda weird and not really clear with the colon operator in-place of range but avoids a for loop.
Does anyone have any suggestions on how to see what is causing the format check to fail? Or what the specifications are?
Does anyone have any suggestions on how to see what is causing the format check to fail? Or what the specifications are?
Sorry about that. This is a change that came into effect only this morning (Europe time). The easiest fix is to run JuliaFormatter on your branch as described in the README.md.
Does anyone have any suggestions on how to see what is causing the format check to fail? Or what the specifications are?
Sorry about that. This is a change that came into effect only this morning (Europe time). The easiest fix is to run JuliaFormatter on your branch as described in the README.md.
Yes I see that now. However it does not appear that the default settings works. Looking at the 'format-check' test, it appears to be flagging files I have not changed.
Formatting /home/runner/work/ReadVTK.jl/ReadVTK.jl/docs/make.jl
Formatting /home/runner/work/ReadVTK.jl/ReadVTK.jl/src/ReadVTK.jl
Formatting /home/runner/work/ReadVTK.jl/ReadVTK.jl/src/get_functions.jl
Formatting /home/runner/work/ReadVTK.jl/ReadVTK.jl/test/pvtk_files.jl
Formatting /home/runner/work/ReadVTK.jl/ReadVTK.jl/test/rectilinear.jl
Formatting /home/runner/work/ReadVTK.jl/ReadVTK.jl/test/runtests.jl
Formatting /home/runner/work/ReadVTK.jl/ReadVTK.jl/test/structuredgrid.jl
Is their a way to share your settings so that it always does yours?
EDIT: Actually I think re-merging with main fixed it. I see there is a settings it needs.
This PR follows up on the accidentally closed PR #28
This PR sets up the workflow between ReadVTK -> WriteVTK by adding
to_meshcell
. Here the changes are:to_meshcell
that convertsVTKCells
type to multiple WriteVTK compliantMeshCells
to_meshcell
correctnessNote that I separated PRs in this to make more sense on an orthogonal feature level. My next PR will include more inclusive testing of ReadVTK -> WriteVTK workflow with ParaView and standard files. But this single test should at least cover testing of the conversion in and of itself.
This PR must be accepted before the larger ParaView one, but I figured it was worth it for clarity to split them up.