search

JuliaVTK / ReadVTK.jl

Julia package for reading VTK XML files
https://juliavtk.github.io/ReadVTK.jl
MIT License
31 stars 10 forks source link

adding support for Structured grid format? #8

Closed jorgepz closed 2 years ago

jorgepz commented 2 years ago

Hi, thanks for your work on ReadVTK.jl, it seems a very useful tool with high potential. I am using WriteVTK.jl in some projects and at some near point I will need to read vtk files as well.

I see that your package does not support the structured grid format. Have you considered adding that? I have some matlab vtk-filereading functions and before migrating them to a simple julia version I would like to consider contributing to this...

Thanks, Jorge

ranocha commented 2 years ago

Thanks for your interest! As noted in the Readmme.md,

ReadVTK was mainly motivated by wanting to write proper tests for Trixi2Vtk.jl. A lot of useful features are still missing (see below), and community contributions to improve this package are welcome!

Thus, your contributions would be welcome, I think. What does the principal developer, @sloede, think about this?

sloede commented 2 years ago

Hi @jorgepz, thanks a lot for reaching out! Since our group is mainly working on unstructured meshes, we do not have the requirement to be able to handle structured meshes. Having said that, we would be very happy to accept contributions to extend ReadVTK.jl's capabilites to structured meshes!

Depending on how much flexibility you need for handling different formats of structured mesh files (VTK really has a lot of ways to store data...), you might need to restructure some internal parts of ReadVTK.jl. However, if the goal is mainly to read in files generated by WriteVTK.jl, this shouldn't be too hard.

What I can offer is to review PRs and discuss possible implementation strategies; I will not, however, be able to contribute much in terms of actual developer time.

If you're interested to contribute, a good way to get in touch is also to join the Trixi Slack, where @ranocha, myself, and the other Trixi devs are available too (to sign up, use the "Slack" badge here).

jorgepz commented 2 years ago

Hi!, thanks both for your replies. I'll have a look at the code in the following days and probably contribute vìa PR or write via slack with questions.

jorgepz commented 2 years ago

opened draft PR for this #9