Closed nhz2 closed 4 months ago
Great, thank you!
Some tests don't pass, maybe not all checksums have been updated? (I haven't tested on my side.)
Just a comment, I would expect StableRNGs to do the right thing and return reproducible values when doing randn(rng)
. That way we wouldn't need to define a my_randn
function. Can this be checked?
randn in StableRNGs seems to be different on 1.11 https://github.com/JuliaRandom/StableRNGs.jl/issues/20 but I think this will be fixed eventually.
my_randn
was returning different values in julia 1.6 because the rounding in cospi
changed. I updated the PR to use rand instead of randn which should be more stable.
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 96.63%. Comparing base (
8e1c1d1
) to head (eacccef
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Thanks!
This PR prevents the test from failing in new versions of Julia if the random number generator changes.